Skip to content

Conversation

@bridadan
Copy link
Contributor

@bridadan bridadan commented Mar 7, 2016

Adds a few missing dependencies to requirements.txt and setup.py

@0xc0170
Copy link
Contributor

0xc0170 commented Mar 7, 2016

Why there is this duplication (req.txt vs setup.py) ?

@bridadan
Copy link
Contributor Author

bridadan commented Mar 7, 2016

requirements.txt allows you to install the dependencies without actually installing the compiled python scripts to your path. It makes development and CI testing easier.

@0xc0170
Copy link
Contributor

0xc0170 commented Mar 7, 2016

requirements.txt allows you to install the dependencies without actually installing the compiled python scripts to your path. It makes development and CI testing easier.

Sorry, I meant why req is not injected into setup.py to avoid duplication. For instance:

# txt stays, but setup.py will include this
requirements = [str(requirement.req) for requirement in parse_requirements('requirements.txt', session=pip.download.PipSession())]

install_requires = requirements

@bridadan
Copy link
Contributor Author

bridadan commented Mar 7, 2016

Oh I do like that. Though that does add a dependency on pip though right? Since parse_requirements is part of the pip package.

Seems like a sensible dependency though. Just wondering if that could be an issue on older systems.

@0xc0170
Copy link
Contributor

0xc0170 commented Mar 8, 2016

We can have a look at this. I'll merge this as it is for now.

0xc0170 added a commit that referenced this pull request Mar 8, 2016
@0xc0170 0xc0170 merged commit 4db2961 into ARMmbed:master Mar 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants